Remove unnecessary pub enum glob-imports from rustc_middle::ty
#132580
Conversation
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
I also understand that the size of these commits are kinda unequal so I'm happy to split out the smaller ones 👍 |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
globs
branch
from
65fc1a1 to
d458f85
Compare
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (096277e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 3.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 779.675s -> 780.065s (0.05%) |
Remove unnecessary pub enum glob-imports from `rustc_middle::ty` We used to have an idiom in the compiler where we'd prefix or suffix all the variants of an enum, for example `BoundRegionKind`, with something like `Br`, and then *glob-import* that enum variant directly. `@noratrieb` brought this up, and I think that it's easier to read when we just use the normal style `EnumName::Variant`. This PR is a bit large, but it's just naming. The only somewhat opinionated change that this PR does is rename `BorrowKind::Imm` to `BorrowKind::Immutable` and same for the other variants. I think these enums are used sparingly enough that the extra length is fine. r? `@noratrieb` or reassign
We used to have an idiom in the compiler where we'd prefix or suffix all the variants of an enum, for example
BoundRegionKind, with something likeBr, and then glob-import that enum variant directly.@Noratrieb brought this up, and I think that it's easier to read when we just use the normal style
EnumName::Variant.This PR is a bit large, but it's just naming.
The only somewhat opinionated change that this PR does is rename
BorrowKind::ImmtoBorrowKind::Immutableand same for the other variants. I think these enums are used sparingly enough that the extra length is fine.r? @Noratrieb or reassign